AVRO-4123: Parsed named schemas always empty #3361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent JDKs alter the requirements for using a security manager. This affects Hadoop code. Also, misplaced javadoc affects tests. When AVRO-4126 is merged, the change to TestSpecificCompiler.java can be reverted.
Contributor
Author
|
The changes to
|
RyanSkraba
changed the title
RyanSkraba
pushed a commit
that referenced
this pull request
Apr 18, 2025
* AVRO-4123: fix missing parsed schemas * AVRO-4123: Remove unnecessary private method * AVRO-4123: Do not use List.getFirst() yet * AVRO-4123: Fix tests for recent JDKs Recent JDKs alter the requirements for using a security manager. This affects Hadoop code. Also, misplaced javadoc affects tests. When AVRO-4126 is merged, the change to TestSpecificCompiler.java can be reverted.
Contributor
|
Cherry-picked to branch-1.12. |
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
* AVRO-4123: fix missing parsed schemas * AVRO-4123: Remove unnecessary private method * AVRO-4123: Do not use List.getFirst() yet * AVRO-4123: Fix tests for recent JDKs Recent JDKs alter the requirements for using a security manager. This affects Hadoop code. Also, misplaced javadoc affects tests. When AVRO-4126 is merged, the change to TestSpecificCompiler.java can be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix AVRO-4123: after parsing, ParseResult#parsedNamedSchemas() is always empty.
Verifying this change
This change altered the test case
TestSchemaParser#testParseByCustomParserto add the omitted check. This is a reasonable place to add this, as other parsers than the core JSON parser are the most likely candidate to use this functionality.Documentation
yes/ no)/ docs / JavaDocs / not documented)