Skip to content

AVRO-3985: [JAVA] adding default serializable pacakge to trusted package list #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhilakshyadobhal wants to merge 4 commits into
base: main
Choose a base branch
from
Open

AVRO-3985: [JAVA] adding default serializable pacakge to trusted package list #3333

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d2a871
HADOOP-19315: [Java] Improve trustedPackages initialization in Specif…
abhilakshyadobhal Mar 8, 2025
0beafc0
AVRO-3985: adding default serializable pacakge to trusted package list
abhilakshyadobhal Mar 11, 2025
bdfff49
added-documentation-for-default-packages
abhilakshyadobhal Mar 22, 2025
0393725
added-documentation-for-default-packages
abhilakshyadobhal Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,24 @@ public class SpecificDatumReader<T> extends GenericDatumReader<T> {

public static final String[] SERIALIZABLE_PACKAGES;

private static final String DEFAULT_PACKAGES = "java.lang,java.math,java.io,java.net,org.apache.avro.reflect";

static {
SERIALIZABLE_PACKAGES = System.getProperty("org.apache.avro.SERIALIZABLE_PACKAGES",
"java.lang,java.math,java.io,java.net,org.apache.avro.reflect").split(",");
String userDefinedPackages = System.getProperty("org.apache.avro.SERIALIZABLE_PACKAGES", DEFAULT_PACKAGES);

/*
* Note:
* - There are some packages that has already been considered trustable by Avro.
* - If a user defines custom packages but does not include these default ones, they may face
* errors when deserializing objects that rely on them.
*/
if ("*".equals(userDefinedPackages)) {
SERIALIZABLE_PACKAGES = new String[]{"*"};
} else {
SERIALIZABLE_PACKAGES = Arrays.stream(userDefinedPackages.split(","))
.distinct()
.toArray(String[]::new);
}
}

private final List<String> trustedPackages = new ArrayList<>();
Expand Down