Close the Jackson Generator to save buffer leaks

[franz1981]

Since FasterXML/jackson-core#919 jackson now requires to close its JsonGenerator to save buffer leaks - and eventually cause further big allocations due to not be able to reuse the existing one.
This can be saved by correctly closing the used JsonGenerator.

[franz1981]

@belugabehr 🙏

[franz1981]

IDK @martin-g if the failure is related to this change

[franz1981]

Hi @jbonofre it's Franz (I was working Artemis years ago) sorry for the naked ping but this one is causing some performance degradation to our Quarkus and Apicurio users, can you take a look? 🙏

[franz1981]

@MichalFoksa there is anything I can do to help here, or anything I am missing? 🙏

[franz1981]

Just for reference, this change is saving to allocate a fresh new 4K sized char[] buffer each time, see https://github.com/FasterXML/jackson-core/blob/bef7d7a199a99f881732758199d8e6d0349bdb28/src/main/java/com/fasterxml/jackson/core/util/BufferRecycler.java#L96

[MichalFoksa]

@franz1981
:( I can't help speed up your issue - I just happened to be the last committer to the main branch. I don’t have any "displacement" in this project.

However, I think closing JsonGenerator could also be useful in:

• org.apache.avro.Protocol#toString(boolean)
• org.apache.avro.Protocol.Message#toString

[franz1981]

do you know @MichalFoksa who I can ping for this?
as said, this is a severe performance issue which can be fixed with a one-liner...

[MichalFoksa]

Maybe @Fokko <https://github.com/Fokko> and @martin-g <https://github.com/martin-g>

…

On Wed, 26 Feb 2025 at 15:53, Francesco Nigro ***@***.***> wrote: do you know @MichalFoksa <https://github.com/MichalFoksa> who I can ping for this? as said, this is a severe performance issue which can be fixed with a one-liner... — Reply to this email directly, view it on GitHub <#3310 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNGENUKBIQ3DF5DM36P7D32RXIQBAVCNFSM6AAAAABW5NQIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGMYDINZQG4> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: franz1981]*franz1981* left a comment (apache/avro#3310) <#3310 (comment)> do you know @MichalFoksa <https://github.com/MichalFoksa> who I can ping for this? as said, this is a severe performance issue which can be fixed with a one-liner... — Reply to this email directly, view it on GitHub <#3310 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNGENUKBIQ3DF5DM36P7D32RXIQBAVCNFSM6AAAAABW5NQIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGMYDINZQG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Fokko]

This is great @franz1981 thanks for making this change! And thanks @MichalFoksa for pinging me 🙌

[franz1981]

Thanks both folks and let me know if you need the follow up others suggested by @MichalFoksa