AVRO-4071: [java] Allow schema redefinition when equal #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParseContext.put accept known schemas when strictly identical. Call to this method was made before schema was fully parsed avoiding exact schema redefinition in files. Call ParseContext.put when schema is fully parsed. This has an inpact on the schemas ordering returned by the parser.
|
Hi, any updates on this PR @cutting ? |
Contributor
|
It took me a while to really understand this PR, and why it changes the parsing behaviour (most notably the order or parse results). I'm also renaming it to match the other reported issue for this. |
opwvhk
changed the title
opwvhk
approved these changes
May 29, 2025
|
@opwvhk, can we get a release for this fix, as we are waiting for same due to the bug fixed in this commit. |
|
We're also facing this issue and having a release would be great! 🙏🏽 |
opwvhk
pushed a commit
that referenced
this pull request
Jun 13, 2025
ParseContext.put accept known schemas when strictly identical. Call to this method was made before schema was fully parsed avoiding exact schema redefinition in files. Call ParseContext.put when schema is fully parsed. This has an inpact on the schemas ordering returned by the parser. (cherry picked from commit cea41a4)
opwvhk
pushed a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
ParseContext.put accept known schemas when strictly identical. Call to this method was made before schema was fully parsed avoiding exact schema redefinition in files. Call ParseContext.put when schema is fully parsed. This has an inpact on the schemas ordering returned by the parser.
4 tasks
Member
|
This change breaks compatibility with previous releases. Seeing this StackOverflowError in Pulsar tests: |
Member
|
I filed https://issues.apache.org/jira/browse/AVRO-4209 about the issue. |
Member
|
@opwvhk @RustedBones Do you have a chance to take a look at https://issues.apache.org/jira/browse/AVRO-4209 since this PR caused the regression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ParseContext.put accept known schemas when strictly identical. Call to this method was made before schema was fully parsed avoiding exact schema redefinition in files.
Call ParseContext.put when schema is fully parsed.
This has an inpact on the schemas ordering returned by the parser.
Verifying this change
Tests were adapted by adding a redefinition of the
MyResponseschema in theApplicationEventrecordDocumentation