Skip to content

[Java] Reduce buffer size for ASCII string optimization to 63 bytes #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 1 commit into from
Feb 3, 2025
Merged

[Java] Reduce buffer size for ASCII string optimization to 63 bytes #3279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lang/java/avro/src/main/java/org/apache/avro/io/BinaryEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@
*/
public abstract class BinaryEncoder extends Encoder {

// Buffer used for writing ASCII strings
private final byte[] stringBuffer = new byte[128];
/*
* Buffer used for writing ASCII strings. A string is encoded as a long followed
* by that many bytes of character data. A string of length 63 is the upper
* limit for a 1 byte variable-length long value.
*/
private final byte[] stringBuffer = new byte[63];

@Override
public void writeNull() throws IOException {
Expand Down
Loading