[Java] Clarify thread safety of Decoders returned by DecoderFactory. #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
requested changes
Jan 4, 2025
Contributor
opwvhk
left a comment
opwvhk
left a comment
There was a problem hiding this comment.
This is a sensible addition. Thank you.
One request though, as the current choice of words looks odd. Can you please replace the first word ("while") with: "although"?
belugabehr
force-pushed
the
belugabehr/thread-safe-factory-javadoc
branch
from
926f9e4 to
f0c189f
Compare
Contributor
Author
|
@opwvhk Done :) |
opwvhk
approved these changes
Jan 4, 2025
opwvhk
pushed a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra noise is from the spotless plugin.