AVRO-4098: [maven-plugin]: make protocol-idl mojo support all compiler options [AVRO-4098] #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep compiler settings DRY, in particular make idl-protocol support for createNullSafeAnnotations flag
AlexRiedler
force-pushed
the
fix-null-annotation-support
branch
from
71b61c8 to
c225a84
Compare
Contributor
|
Thank you for this change, @AlexRiedler! I've taken the liberty of adding a test case that demonstrates the flag for |
Contributor
Author
|
@opwvhk thanks for the review 🙏🏻 , and thanks for adding the missing test case! |
opwvhk
added a commit
that referenced
this pull request
Jun 13, 2025
…r options [AVRO-4098] (#3261) * AVRO-40980: [maven-plugin] make mojos support all compiler options Keep compiler settings DRY, in particular make idl-protocol support for createNullSafeAnnotations flag * AVRO-4098: Add test case --------- Co-authored-by: Oscar Westra van Holthe - Kind <opwvhk@apache.org> (cherry picked from commit 70d6e7c)
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
…r options [AVRO-4098] (apache#3261) * AVRO-40980: [maven-plugin] make mojos support all compiler options Keep compiler settings DRY, in particular make idl-protocol support for createNullSafeAnnotations flag * AVRO-4098: Add test case --------- Co-authored-by: Oscar Westra van Holthe - Kind <opwvhk@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Allows idl-protocol maven plugin to support createNullSafeAnnotations flag (which is currently defined, but has no effect since missing
compiler.setCreateNullSafeAnnotations(createNullSafeAnnotations).Also lined up settings so they are not repeated between Mojos so this does not happen again.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation