AVRO-4045: Use JDK compare for byte arrays #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belugabehr
force-pushed
the
belugabehr/jdk-compare
branch
from
4b05b82 to
ff3d409
Compare
martin-g
approved these changes
Sep 9, 2024
| * Lexicographically compare bytes. If equal, return zero. If greater-than, | ||
| * return a positive value, if less than return a negative value. | ||
| */ | ||
| public static int compareBytes(byte[] b1, int s1, int l1, byte[] b2, int s2, int l2) { |
Member
There was a problem hiding this comment.
This method could be marked as deprecated for 1.12 and removed in 1.13.0
Contributor
Author
There was a problem hiding this comment.
OK. Will try to follow up, but I always worry about pulling back stuff and adding any kind of friction to consumers to upgrade.
Contributor
There was a problem hiding this comment.
It appears this public method has users, and this change was noticed in #3537! We should probably keep this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
Documentation