Skip to content

Conversation

@jbonofre
Copy link
Member

What is the purpose of the change

This is backport PR (on branch-1.11) for AVRO-3985.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

NB: let me work on doc update separately.

@jbonofre jbonofre requested review from Fokko and martin-g June 26, 2024 12:06
@github-actions github-actions bot added the Java Pull Requests for Java binding label Jun 26, 2024
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbonofre

@Fokko Fokko merged commit 8f89868 into apache:branch-1.11 Jun 26, 2024
@jbonofre jbonofre deleted the AVRO-3985-branch-1.11 branch June 28, 2024 11:56
dongjoon-hyun added a commit to apache/spark that referenced this pull request Jan 19, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade Avro to 1.11.4.

### Why are the changes needed?

To bring the latest bug fixes like the following.
- https://github.com/apache/avro/releases/tag/release-1.11.3
    - apache/avro#2432
    - apache/avro#2318
    - apache/avro#1720
- https://github.com/apache/avro/releases/tag/release-1.11.4
    - apache/avro#2980

### Does this PR introduce _any_ user-facing change?

Yes, this is a dependency change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49563 from dongjoon-hyun/SPARK-50886.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@podmak
Copy link

podmak commented Mar 3, 2025

hi @jbonofre , can I ask why trustedPackaged inicialization was not added also to this constructor https://github.com/apache/avro/pull/2980/files#diff-95af304493048b22c3dda8fbfc7efb0e0c1c5e876f0234c2b8d0635bb2bcb494R76 ?
how can I set values in trustedPackages in this case?

@jbonofre
Copy link
Member Author

jbonofre commented Mar 3, 2025

@podmak that's a good question. What I proposed was an implicit loading in ReflectData without impact on existing code, so without changing the constructor. That's why I did the static init and check in the SpecificDatumReader(writer, reader, data) constructor, as it's only one I found used.

I think you are right, SpecificDatumReader(data) constructor should also check the trusted package. Let me do a new PR to fix that.

@jbonofre
Copy link
Member Author

jbonofre commented Mar 3, 2025

@podmak I created #3330 related to what we discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants