Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions native-engine/auron-planner/proto/auron.proto
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ enum WindowFunction {
ROW_NUMBER = 0;
RANK = 1;
DENSE_RANK = 2;
LAG = 3;
}

enum AggFunction {
Expand Down
1 change: 1 addition & 0 deletions native-engine/auron-planner/src/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@ impl PhysicalPlanner {
protobuf::WindowFunction::DenseRank => {
WindowFunction::RankLike(WindowRankType::DenseRank)
}
protobuf::WindowFunction::Lag => WindowFunction::Lag,
},
protobuf::WindowFunctionType::Agg => match w.agg_func() {
protobuf::AggFunction::Min => WindowFunction::Agg(AggFunction::Min),
Expand Down
10 changes: 8 additions & 2 deletions native-engine/datafusion-ext-plans/src/window/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ use crate::{
agg::{AggFunction, agg::create_agg},
window::{
processors::{
agg_processor::AggProcessor, rank_processor::RankProcessor,
row_number_processor::RowNumberProcessor,
agg_processor::AggProcessor, lag_processor::LagProcessor,
rank_processor::RankProcessor, row_number_processor::RowNumberProcessor,
},
window_context::WindowContext,
},
Expand All @@ -36,6 +36,7 @@ pub mod window_context;
#[derive(Debug, Clone, Copy)]
pub enum WindowFunction {
RankLike(WindowRankType),
Lag,
Agg(AggFunction),
}

Expand Down Expand Up @@ -87,6 +88,7 @@ impl WindowExpr {
WindowFunction::RankLike(WindowRankType::DenseRank) => {
Ok(Box::new(RankProcessor::new(true)))
}
WindowFunction::Lag => Ok(Box::new(LagProcessor::new(self.children.clone()))),
WindowFunction::Agg(agg_func) => {
let agg = create_agg(
agg_func.clone(),
Expand All @@ -98,4 +100,8 @@ impl WindowExpr {
}
}
}

pub fn requires_full_partition(&self) -> bool {
matches!(self.func, WindowFunction::Lag)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
// Licensed to the Apache Software Foundation (ASF) under one or more
// contributor license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright ownership.
// The ASF licenses this file to You under the Apache License, Version 2.0
// (the "License"); you may not use this file except in compliance with
// the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use std::sync::Arc;

use arrow::{array::ArrayRef, datatypes::DataType, record_batch::RecordBatch};
use datafusion::{
common::{DataFusionError, Result, ScalarValue},
physical_expr::PhysicalExprRef,
};
use datafusion_ext_commons::arrow::cast::cast;

use crate::window::{WindowFunctionProcessor, window_context::WindowContext};

pub struct LagProcessor {
children: Vec<PhysicalExprRef>,
}

impl LagProcessor {
pub fn new(children: Vec<PhysicalExprRef>) -> Self {
Self { children }
}
}

impl WindowFunctionProcessor for LagProcessor {
fn process_batch(&mut self, context: &WindowContext, batch: &RecordBatch) -> Result<ArrayRef> {
assert_eq!(
self.children.len(),
3,
"lag expects input/offset/default children",
);
Comment on lines +39 to +43

let input_values = self.children[0]
.evaluate(batch)
.and_then(|v| v.into_array(batch.num_rows()))?;

let offset_values = self.children[1]
.evaluate(batch)
.and_then(|v| v.into_array(batch.num_rows()))?;
let offset_values = if offset_values.data_type() == &DataType::Int32 {
offset_values
} else {
cast(&offset_values, &DataType::Int32)?
};
let offset = match ScalarValue::try_from_array(&offset_values, 0)? {
ScalarValue::Int32(Some(offset)) => offset as i64,
other => {
return Err(DataFusionError::Execution(format!(
"lag offset must be a non-null foldable integer, got {other:?}",
)));
}
};

Comment on lines +45 to +65
let default_values = self.children[2]
.evaluate(batch)
.and_then(|v| v.into_array(batch.num_rows()))?;
let default_values = if default_values.data_type() == input_values.data_type() {
default_values
} else {
cast(&default_values, input_values.data_type())?
};

let mut partition_starts = vec![0usize; batch.num_rows()];
let mut partition_ends = vec![batch.num_rows(); batch.num_rows()];
if context.has_partition() && batch.num_rows() > 0 {
let partition_rows = context.get_partition_rows(batch)?;
let mut partition_start = 0usize;
for row_idx in 1..=batch.num_rows() {
let is_boundary = row_idx == batch.num_rows()
|| partition_rows.row(row_idx).as_ref()
!= partition_rows.row(partition_start).as_ref();
if is_boundary {
for idx in partition_start..row_idx {
partition_starts[idx] = partition_start;
partition_ends[idx] = row_idx;
}
partition_start = row_idx;
}
}
}

let mut output = Vec::with_capacity(batch.num_rows());
for row_idx in 0..batch.num_rows() {
// lag looks backward: target is offset rows before current row
let target_idx = row_idx as i64 - offset;
let partition_start = partition_starts[row_idx] as i64;
let partition_end = partition_ends[row_idx] as i64;
let value = if target_idx >= partition_start && target_idx < partition_end {
ScalarValue::try_from_array(&input_values, target_idx as usize)?
} else {
ScalarValue::try_from_array(&default_values, row_idx)?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the row-by-row ScalarValue::try_from_array + ScalarValue::iter_to_array pattern creates N heap-allocated scalar objects. For large partitions that full-partition buffering implies, this is will become an issue. Can we use arrow::compute::take with a pre-computed indices array to gather values in O(1) allocations?

};
output.push(value);
}

ScalarValue::iter_to_array(output)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
// limitations under the License.

pub mod agg_processor;
pub mod lag_processor;
pub mod rank_processor;
pub mod row_number_processor;
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,10 @@ impl WindowContext {
.collect::<Result<Vec<_>>>()?,
)?)
}

pub fn requires_full_partition(&self) -> bool {
self.window_exprs
.iter()
.any(|expr| expr.requires_full_partition())
}
}
Loading