Skip to content

GH-49764: [C++][Python] Avoid building bundled Abseil outside resolve_dependency#49936

Merged
kou merged 1 commit intoapache:mainfrom
raulcd:GH-49764
May 7, 2026
Merged

GH-49764: [C++][Python] Avoid building bundled Abseil outside resolve_dependency#49936
kou merged 1 commit intoapache:mainfrom
raulcd:GH-49764

Conversation

@raulcd
Copy link
Copy Markdown
Member

@raulcd raulcd commented May 6, 2026

Rationale for this change

With the bump versions for gRPC/Protobuf/Abseil and others a bug was introduced where we build Abseil outside of resolve dependency. This caused to interpret Abseil as System dependency for Arrow Flight when it was bundled and failing to find it when trying to build PyArrow.

What changes are included in this PR?

Reorder resolve_dependency abseil to be done before resolving protobuf in order to not require manually building abseil.

Are these changes tested?

Yes via CI, via archery and validated the local build that previously failed now succeeds

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

⚠️ GitHub issue #49764 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented May 6, 2026

@github-actions crossbow submit verify-rc-source-python-linux-*

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Revision: c8be506

Submitted crossbow builds: ursacomputing/crossbow @ actions-71cba4b15c

Task Status
verify-rc-source-python-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-24.04-amd64 GitHub Actions

@raulcd raulcd added CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI CI: Extra: R Run extra R CI labels May 6, 2026
@raulcd raulcd marked this pull request as ready for review May 6, 2026 13:10
@raulcd raulcd requested a review from kou May 6, 2026 13:11
@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented May 7, 2026

@kou this is just re-ordering resolve dependencies.
It avoids some wrong assumptions down the line due to an early build Abseil from Protobuf, andFlight setting flags as if Abseil is a system dependency instead of being bundled.
As is just moving things around (plus a couple more checks due to Abseil being built for Protobuf) I plan to merge this if no concerns are raised.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 34414b5 into apache:main May 7, 2026
165 of 192 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label May 7, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label May 7, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 34414b5.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI CI: Extra: R Run extra R CI Component: C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants