Skip to content

MINOR: [C++][Parquet][Doc] pointer dereference instead of dot in parquet.rst#49932

Open
alexeyroytman wants to merge 1 commit intoapache:mainfrom
alexeyroytman:main
Open

MINOR: [C++][Parquet][Doc] pointer dereference instead of dot in parquet.rst#49932
alexeyroytman wants to merge 1 commit intoapache:mainfrom
alexeyroytman:main

Conversation

@alexeyroytman
Copy link
Copy Markdown

Rationale for this change

Example code did not compile because it used dot (.) instead of arrow (->) in C++ code.

What changes are included in this PR?

One C++ example code in a documentation to have dot (.) replaced by arrow (->).

Are these changes tested?

Manually, when I've tried to copy-and-paste example, and it did not compile.

Are there any user-facing changes?

One external example will change.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@alexeyroytman alexeyroytman changed the title [C++ doc] pointer dereference instead of dot in parquet.rst [C++][Parquet][Doc] pointer dereference instead of dot in parquet.rst May 6, 2026
@alexeyroytman alexeyroytman changed the title [C++][Parquet][Doc] pointer dereference instead of dot in parquet.rst MINOR: [C++][Parquet][Doc] pointer dereference instead of dot in parquet.rst May 6, 2026
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me an in-line with our example in:

std::shared_ptr<WriterProperties> props = WriterProperties::Builder()
.compression(Compression::SNAPPY) // Fallback
->compression("colA", Compression::ZSTD) // Only applies to column "colA"
->encoding(Encoding::BIT_PACKED) // Fallback
->encoding("colB", Encoding::RLE) // Only applies to column "colB"
->disable_dictionary("colB") // Never dictionary-encode column "colB"
->build();

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 6, 2026
@alexeyroytman
Copy link
Copy Markdown
Author

My further only concern was the indentation (2 in my case, 3 in the case @raulcd mentioned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants