GH-49503: [Docs][Python] Documenting .pxi doctests are tested via lib.pyx#49515
Open
bhavanaeh wants to merge 1 commit intoapache:mainfrom
Open
GH-49503: [Docs][Python] Documenting .pxi doctests are tested via lib.pyx#49515bhavanaeh wants to merge 1 commit intoapache:mainfrom
bhavanaeh wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
bhavanaeh
commented
Mar 15, 2026
| for ``.pyx`` and ``.pxi`` files. In this case you will also need to | ||
| install the `pytest-cython <https://github.com/lgpage/pytest-cython>`_ plugin. | ||
|
|
||
| .. note:: |
Author
There was a problem hiding this comment.
I went with a .. note:: block to make this stand out, but happy to change it to inline text if that's preferred.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Running
python -m pytest --doctest-cythondirectly on.pxifiles doesn't work because Cython.pxifiles are included in.pyxfiles at compile time. This isn't documented, which could potentially confuse contributors.Please see discussion in #49279 (comment) by @AlenkaF for additional context.
What changes are included in this PR?
Added a
noteto the Doctest section of the Developing PyArrow documentation explaining that:.pxifiles cannot be tested directly with--doctest-cython.pyxfile they are included in (e.g.,lib.pyx).pyxfile, not the original.pxifilenameAre these changes tested?
Documentation-only change. No code changes.
Are there any user-facing changes?
No.