MINOR: [Doc][CI] Fix doctests failing on pandas 3 string types examples #49088
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
awaiting committer review
rok
changed the title
rok
force-pushed
the
fix_doctest_issues
branch
from
060eab3 to
f14ade1
Compare
|
|
||
| >>> print(dict_array.type) | ||
| dictionary<values=string, indices=int64, ordered=0> | ||
| dictionary<values=...string, indices=int64, ordered=0> |
Member
There was a problem hiding this comment.
This one should not be needed? (the dictionary here is created just through pyarrow, no pandas involved?)
| 7 baz | ||
| dtype: category | ||
| Categories (3, object): ['foo', 'bar', 'baz'] | ||
| Categories (3, ...): ['foo', 'bar', 'baz'] |
Member
There was a problem hiding this comment.
FWIW, I think if we know the doctests will run on an instance with pandas>=3, I would just update those to use pandas 3 output, because that will be less confusing for people reading the docs ("what do those 3 dots mean here?").
Suggested change
| Categories (3, ...): ['foo', 'bar', 'baz'] | |
| Categories (3, str): ['foo', 'bar', 'baz'] |
| >>> schema | ||
| f0: int64 | ||
| f1: string | ||
| f1: ...string |
Member
There was a problem hiding this comment.
Also here, is this actually needed? The example here is pure pyarrow, and that should always be using pyarrow's default of "string" ?
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #48619 (comment)
Rationale for this change
Fix CI failures
What changes are included in this PR?
Tests are made more general to allow for Pandas 2 and Pandas 3 style string types
Are these changes tested?
By CI
Are there any user-facing changes?
No