GH-49079: [C++] Fix null pointer dereference in SimpleTable constructor #49086
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SimpleTable constructors dereference columns_[0] and columns[0] without checking for null when num_rows < 0. This causes a segfault if a user passes a vector containing null pointers, as the null check in ValidateMeta() runs after construction. Fixed by adding null checks before dereferencing the first column.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for This Change
The
SimpleTableconstructor incpp/src/arrow/table.cccan crash if the first column provided isnull. This happens because the constructor attempts to dereferencecolumns[0]to determine the row count before performing any validation.This change ensures safe initialization when columns are empty or the first column is null.
What Changes Are Included in This PR?
A null-pointer safety check has been added to both
SimpleTableconstructors to prevent dereferencing a null column during initialization:Are These Changes Tested?
Yes. The change has been verified using the existing unit test suite.
Are There Any User-Facing Changes?
No. This change only improves internal safety and does not affect public APIs or user-visible behavior.
Closes
Closes #49079