-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-49037: [Benchmarking] Install R from non-conda source for benchmarking #49038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit 70dd4d3. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 70dd4d3. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
This PR adds an However, this PR alone isn't sufficient - the benchmark CI infrastructure lives in a separate repo (https://github.com/arctosalliance/arrow-benchmarks-ci) which currently includes r in its conda environment creation. Even though this PR adds Companion PR needed: arctosalliance/arrow-benchmarks-ci#1 - removes r from conda env and calls the The arctosalliance PR depends on this one being merged first. |
|
@rok This has got a bit messy as there may be code duplicated between the arctos repo and the Arrow repo, but I think this makes sense? Or do you reckon I should I move all of this to the other repo so we don't have dependent PRs? |
rok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible @thisisnic, please merge and verify and ping me if there's another cycle needed.
Rationale for this change
Slow benchmarks due to conda duckdb building from source
What changes are included in this PR?
Try ditching conda and installing R via rig and using PPM binaries
Are these changes tested?
I'll try running
Are there any user-facing changes?
Nope