GH-49034 [C++][Gandiva] Fix binary_string to not trigger error for nu… #49035
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for null strings.
|
|
github-actions
bot
added
Component: C++
Component: Gandiva
awaiting review
| gdv_int32* out_len) { | ||
| if (text_len == 0) { | ||
| *out_len = 0; | ||
| return ""; |
There was a problem hiding this comment.
Java version is NullHandling.NULL_IF_NULL
Are we going to return empty string for null? If so - that's inconsistency we can't have.
Contributor
Author
There was a problem hiding this comment.
It returns null, the same as Java.
github-actions
bot
added
awaiting committer review
dmitry-chirkov-dremio
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll strings.
Rationale for this change
Fixes GH-49034.
The binary_string funcion will attempt to allocate 0 bytes of memory, which results in a null ptr being returned and the function interprets that as an error.
What changes are included in this PR?
Add kCanReturnErrors to the function definition to match other string functions.
Move the check for 0 byte length input earlier in the binary_string function to prevent the 0 allocation.
Add a unit test.
Are these changes tested?
Yes, unit and integration testing.
Are there any user-facing changes?
No.