-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using cpp_test.sh
#49005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Run test executables once without re-runs and without using test script. This way the segmentation fault is not caught.
|
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly this test segfaults if not run in isolation and run as part of ci/scripts/cpp_test.sh?
I am not an expert here but if my understanding is correct I think we should rather investigate why it segfaults instead of hiding it.
Attempt to run `cpp_test.sh` to run tests from Apache Arrow ODBC and the Arrow libraries used by ODBC. Since ODBC test doesn't fail with segmentation fault, removed TODO comment.
In mid-November 2025, ODBC tests on Windows failed with a segmentation fault, which can only detected via exit code checks (as done by Thanks to your comment reminder Raul, now I realize the ODBC tests are no longer having with segmentation fault on MSVC Windows. I think the underlying issue was resolved by recent updates in the Arrow libraries used by ODBC. I've remove the TODO comment for segmentation fault. I have pushed a commit to test |
Created apache#49050 to enable it
cpp_test.shcpp_test.sh
alinaliBQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the PR to run cpp_test.sh since it works now.
| # Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI. | ||
| # GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI. | ||
| ARROW_CSV: OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found segmentation fault at find_package(Arrow) example in cpp_test.sh that doesn't seem to be ODBC-related. Raised #49050
Rationale for this change
#49004
What changes are included in this PR?
cpp_test.shin the ODBC job of C++ Extra CI.Note:
find_package(Arrow)check incpp_test.shis disabled due to blocker [C++] Enable Minimal Find Arrow package test for MSVC CI with VCPKG #49050Are these changes tested?
Yes, in CI
Are there any user-facing changes?
N/A
cpp_test.sh#49004