Skip to content

Conversation

@alinaliBQ
Copy link
Collaborator

@alinaliBQ alinaliBQ commented Jan 27, 2026

Rationale for this change

#49004

What changes are included in this PR?

Are these changes tested?

Yes, in CI

Are there any user-facing changes?

N/A

Run test executables once without re-runs and without using test script. This way the segmentation fault is not caught.
@github-actions
Copy link

⚠️ GitHub issue #49004 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added CI: Extra: C++ Run extra C++ CI awaiting review Awaiting review labels Jan 27, 2026
@alinaliBQ alinaliBQ marked this pull request as ready for review January 27, 2026 19:30
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 27, 2026
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this test segfaults if not run in isolation and run as part of ci/scripts/cpp_test.sh?
I am not an expert here but if my understanding is correct I think we should rather investigate why it segfaults instead of hiding it.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 28, 2026
Attempt to run `cpp_test.sh` to run tests from Apache Arrow ODBC and the Arrow libraries used by ODBC.

Since ODBC test doesn't fail with segmentation fault, removed TODO comment.
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 28, 2026
@alinaliBQ
Copy link
Collaborator Author

alinaliBQ commented Jan 28, 2026

If I understand correctly this test segfaults if not run in isolation and run as part of ci/scripts/cpp_test.sh? I am not an expert here but if my understanding is correct I think we should rather investigate why it segfaults instead of hiding it.

In mid-November 2025, ODBC tests on Windows failed with a segmentation fault, which can only detected via exit code checks (as done by cpp_test.sh) or running $LASTEXITCODE command on PowerShell on the local Windows. When I raised the PR, I didn't realize that the workflow CI would have failed if the ODBC test executable had segmentation fault, since the CI checks for exit code as well. 😅

Thanks to your comment reminder Raul, now I realize the ODBC tests are no longer having with segmentation fault on MSVC Windows. I think the underlying issue was resolved by recent updates in the Arrow libraries used by ODBC.

I've remove the TODO comment for segmentation fault. I have pushed a commit to test cpp_test.sh, if cpp_test.sh works, I will remove the extra ODBC test steps.

@alinaliBQ alinaliBQ changed the title GH-49004: [C++][FlightRPC] Run ODBC tests in workflow without cpp_test.sh GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using cpp_test.sh Jan 28, 2026
Copy link
Collaborator Author

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the PR to run cpp_test.sh since it works now.

Comment on lines +356 to +358
# Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI.
# GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI.
ARROW_CSV: OFF
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found segmentation fault at find_package(Arrow) example in cpp_test.sh that doesn't seem to be ODBC-related. Raised #49050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review Awaiting change review CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants