GH-47914: [C++] Fix system Apache ORC/Google logging used detection#47915
Merged
raulcd merged 2 commits intoapache:mainfrom Oct 23, 2025
Merged
GH-47914: [C++] Fix system Apache ORC/Google logging used detection#47915raulcd merged 2 commits intoapache:mainfrom
raulcd merged 2 commits intoapache:mainfrom
Conversation
We need to use `orc_SOURCE` not `ORC_SOURCE`.
|
|
github-actions
bot
added
Component: C++
awaiting committer review
raulcd
reviewed
Oct 23, 2025
github-actions
bot
added
awaiting changes
kou
changed the title
github-actions
bot
added
awaiting change review
Member
|
@github-actions crossbow submit -g cpp |
raulcd
approved these changes
Oct 23, 2025
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
👍 LGTM, will merge once CI finishes if successful
github-actions
bot
added
awaiting merge
|
Revision: 1cef7e1 Submitted crossbow builds: ursacomputing/crossbow @ actions-11243595d4
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 603901a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
…tion (apache#47915) ### Rationale for this change We need to use `orc_SOURCE` not `ORC_SOURCE` for Apache ORC and `glog_SOURCE` not `GLOG_SOURCE` for Google logging. ### What changes are included in this PR? Fix referred variable names. ### Are these changes tested? Yes in apache/arrow-java#865 . ### Are there any user-facing changes? Yes. * GitHub Issue: apache#47914 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to use
orc_SOURCEnotORC_SOURCEfor Apache ORC andglog_SOURCEnotGLOG_SOURCEfor Google logging.What changes are included in this PR?
Fix referred variable names.
Are these changes tested?
Yes in apache/arrow-java#865 .
Are there any user-facing changes?
Yes.