GH-47196: [CI][C++] Add Windows ARM64 build #47811
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: C++ Windows MSVC Reusable | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| arch: | ||
| description: "The architecture to build for" | ||
| required: true | ||
| type: string | ||
| os: | ||
| description: "The runner label to run the job on" | ||
| required: true | ||
| type: string | ||
| simd-level: | ||
| description: "The Arrow SIMD level to build with" | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| windows: | ||
| runs-on: ${{ inputs.os }} | ||
| timeout-minutes: 60 | ||
| env: | ||
| ARROW_BOOST_USE_SHARED: OFF | ||
| ARROW_BUILD_BENCHMARKS: ON | ||
| ARROW_BUILD_SHARED: ON | ||
| ARROW_BUILD_STATIC: OFF | ||
| ARROW_BUILD_TESTS: ON | ||
| ARROW_DATASET: ON | ||
| ARROW_FLIGHT: OFF | ||
| ARROW_HDFS: ON | ||
| ARROW_HOME: /usr | ||
| ARROW_JEMALLOC: OFF | ||
| ARROW_MIMALLOC: ON | ||
| ARROW_ORC: ON | ||
| ARROW_PARQUET: ON | ||
| ARROW_SIMD_LEVEL: ${{ inputs.simd-level }} | ||
| ARROW_SUBSTRAIT: ON | ||
| ARROW_USE_GLOG: OFF | ||
| ARROW_VERBOSE_THIRDPARTY_BUILD: OFF | ||
| ARROW_WITH_BROTLI: OFF | ||
| ARROW_WITH_BZ2: OFF | ||
| ARROW_WITH_LZ4: OFF | ||
| ARROW_WITH_OPENTELEMETRY: OFF | ||
| ARROW_WITH_SNAPPY: ON | ||
| ARROW_WITH_ZLIB: ON | ||
| ARROW_WITH_ZSTD: ON | ||
| BOOST_SOURCE: BUNDLED | ||
| CMAKE_CXX_STANDARD: "17" | ||
| CMAKE_GENERATOR: Ninja | ||
| CMAKE_INSTALL_PREFIX: /usr | ||
| CMAKE_UNITY_BUILD: ON | ||
| steps: | ||
| - name: Disable Crash Dialogs | ||
| run: | | ||
| reg add ` | ||
| "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" ` | ||
| /v DontShowUI ` | ||
| /t REG_DWORD ` | ||
| /d 1 ` | ||
| /f | ||
| - name: Checkout Arrow | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
| submodules: recursive | ||
| - name: Download Timezone Database | ||
| shell: bash | ||
| run: ci/scripts/download_tz_database.sh | ||
| - name: Install msys2 (for tzdata for ORC tests) | ||
| uses: msys2/setup-msys2@v2 | ||
| id: setup-msys2 | ||
| - name: Install cmake | ||
| shell: bash | ||
| run: | | ||
| ci/scripts/install_cmake.sh 4.1.2 /usr | ||
| - name: Install ccache | ||
| shell: bash | ||
| run: | | ||
| ci/scripts/install_ccache.sh 4.12.1 /usr | ||
| - name: Setup ccache | ||
| shell: bash | ||
| run: | | ||
| ci/scripts/ccache_setup.sh | ||
| - name: ccache info | ||
| id: ccache-info | ||
| shell: bash | ||
| run: | | ||
| echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT | ||
| - name: Cache ccache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ${{ steps.ccache-info.outputs.cache-dir }} | ||
| key: cpp-ccache-windows-${{ inputs.arch }}-${{ hashFiles('cpp/**') }} | ||
| restore-keys: cpp-ccache-windows-${{ inputs.arch }}- | ||
| - name: Build | ||
| shell: cmd | ||
| run: | | ||
| call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" ${{ inputs.arch }} | ||
| bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" | ||
| - name: Test | ||
| shell: cmd | ||
| run: | | ||
| call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" ${{ inputs.arch }} | ||
| # For ORC | ||
| set TZDIR=${{ steps.setup-msys2.outputs.msys2-location }}\usr\share\zoneinfo | ||
| bash -c "ci/scripts/cpp_test.sh $(pwd) $(pwd)/build" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1118,6 +1118,11 @@ function(build_boost) | |
| # This is for https://github.com/boostorg/container/issues/305 | ||
| string(APPEND CMAKE_C_FLAGS " -Wno-strict-prototypes") | ||
| endif() | ||
| if(MSVC AND "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ARM64") | ||
| set(BOOST_CONTEXT_IMPLEMENTATION | ||
| winfib | ||
| CACHE STRING "" FORCE) | ||
|
Member
There was a problem hiding this comment. Do we need to use
Contributor
Author
There was a problem hiding this comment. Yes, otherwise it will default to
Member
There was a problem hiding this comment. Hmm. Could you try diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index e805694f52..ca6b9e8746 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -71,6 +71,12 @@ cmake_policy(SET CMP0090 NEW)
# MSVC runtime library flags are selected by an abstraction.
cmake_policy(SET CMP0091 NEW)
+# https://cmake.org/cmake/help/latest/policy/CMP0126.html
+#
+# The set(CACHE) command does not remove any normal variable of the
+# same name from the current scope.
+cmake_policy(SET CMP0126 NEW)
+
# https://cmake.org/cmake/help/latest/policy/CMP0135.html
#
# CMP0135 is for solving re-building and re-downloading.
Contributor
Author
There was a problem hiding this comment. sadly it didn't work :/ |
||
| endif() | ||
| set(CMAKE_UNITY_BUILD OFF) | ||
|
|
||
| fetchcontent_makeavailable(boost) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.