feat(parquet): relax type compatility check in parquet ArrowWriter #9099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @albertlockett this overlaps/extends some of your recent work. |
albertlockett
approved these changes
Jan 6, 2026
Contributor
albertlockett
left a comment
albertlockett
left a comment
There was a problem hiding this comment.
looks good. Thanks @gruuya
gruuya
changed the title
Contributor
|
I don't think it does, but can you confirm this doesn't conflict with #9077 |
Contributor
Author
I think it doesn't. To confirm i checked out your |
alamb
approved these changes
Jan 6, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @gruuya @albertlockett and @tustvold
9 tasks
Contributor
|
Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LevelInfoBuilder::types_compatibleforArrowWriter#9098.Rationale for this change
Don't require strict equality for nested fields (including inner field name/metadata), just require that nested data types are logically equivalent.
What changes are included in this PR?
Use
a.equals_datatype(b)instead ofa == bat the start ofLevelInfoBuilder::types_compatible.Are these changes tested?
Yes.
Are there any user-facing changes?