chore: Support decimal32, decimal64, and dictionaries in integration test utilities#880
Open
paleolimbot wants to merge 10 commits intoapache:mainfrom
Open
chore: Support decimal32, decimal64, and dictionaries in integration test utilities#880paleolimbot wants to merge 10 commits intoapache:mainfrom
paleolimbot wants to merge 10 commits intoapache:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
paleolimbot
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 79.96% 79.25% -0.72%
==========================================
Files 105 106 +1
Lines 15461 15938 +477
Branches 1738 1851 +113
==========================================
+ Hits 12364 12631 +267
- Misses 1998 2147 +149
- Partials 1099 1160 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pursuit of removing skips in the integration test for apache/arrow#49910 . While the IPC reader has supported Decimal 32 and 64 since the beginning, the JSON parser hasn't.
The file reader for the integration tests also was never updated to support dictionary batches. To fully support the integration test we also need a writer for dictionaries which is a bit more involved and I'll do it in another PR.