-
Notifications
You must be signed in to change notification settings - Fork 70
fix test failures on 1.12 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 87.43% 86.96% -0.48%
==========================================
Files 26 27 +1
Lines 3288 3399 +111
==========================================
+ Hits 2875 2956 +81
- Misses 413 443 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| x = x.data | ||
| len = length(x) | ||
| validity = ValidityBitmap(x) | ||
| # XXX This is a race condition if two workers hit this block at the same time, then they'll create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quinnj I think there is a race condition baked into the current architecture that can't be addressed without a very large refactoring. The current architecture creates the locks on a worker thread if they don't already exist, which means that threads are competing for the creation of the initial lock. The locks should be created before any tasks are spawned.
No description provided.