GH-155: Delegate opening mTLS cert files to build()#783
Open
rtadepalli wants to merge 2 commits intoapache:mainfrom
Open
GH-155: Delegate opening mTLS cert files to build()#783rtadepalli wants to merge 2 commits intoapache:mainfrom
build()#783rtadepalli wants to merge 2 commits intoapache:mainfrom
Conversation
rtadepalli
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
Contributor
Author
|
Could I please get a review @lidavidm thanks. |
Member
|
Sorry - I have basically 0 time for arrow-java recently. I will try to get to all the reviews soon but I can't make any promises. |
lidavidm
reviewed
Jun 23, 2025
| return this; | ||
| } | ||
|
|
||
| private void prepareTlsSettings() throws IOException { |
Member
There was a problem hiding this comment.
The way this is written, if you set the File version then the deprecated version never takes effect, even if you set it afterwards. I suppose that's OK given the deprecation.
Comment on lines
+229
to
+231
| closeMTlsCACert(); | ||
| closeCertChain(); | ||
| closeKey(); |
Member
There was a problem hiding this comment.
Honestly, this should be in a try-finally wrapping the entire build() call (since other exceptions in between this and the actual TLS settings will leak the handles). Either that, or this should be moved down to right before we use the file handles (and should still be in a try-finally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Make
FlightServer.BuilderstoreFileand delegate opening the file to the actualbuild()method.Closes #155.