MINOR: Update versions in LICENSE/NOTICE#652
Conversation
This comment has been minimized.
This comment has been minimized.
| --------------------------------------------------- | ||
|
|
||
| This product includes Netty 4.1.117.Final, with the following in its NOTICE: | ||
| This product includes Netty 4.1.119.Final, with the following in its NOTICE: |
There was a problem hiding this comment.
It seems that https://github.com/apache/arrow-java/tree/main/flight/flight-sql-jdbc-driver doesn't include copy of part of Netty. Do we need this? (Or should we change this to "This binary artifact contains ..."?)
There was a problem hiding this comment.
JDBC driver actually shades Netty (using org/apache/arrow/driver/jdbc/shaded relocation).
For instance:
$ jar tvf flight-sql-jdbc-driver-19.0.0-SNAPSHOT.jar|grep -i netty
...
org/apache/arrow/driver/jdbc/shaded/io/netty/handler/codec/http2/Http2FrameLogger$Direction.class
org/apache/arrow/driver/jdbc/shaded/io/netty/handler/codec/http2/Http2Exception$ClosedStreamCreationException.class
org/apache/arrow/driver/jdbc/shaded/io/netty/handler/codec/http2/Http2FrameCodec.class
org/apache/arrow/driver/jdbc/shaded/io/netty/handler/codec/http2/Http2PushPromiseFrame.class
...
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm not familiar with Java but I thought flight-sql-jdbc-driver-19.0.0-SNAPSHOT.jar is a binary artifact not a source archive. (I thought that https://repository.apache.org/content/repositories/staging/org/apache/arrow/flight-sql-jdbc-driver/18.2.0/flight-sql-jdbc-driver-18.2.0-sources.jar is a source archive for flight-sql-jdbc-driver.)
We use "This binary artifact contains ..." in other files for binary artifact and we use "This product includes ..." for copied sources. e.g.:
Line 205 in cf8b252
So I thought:
- We don't need this for source archive?
- We should use "This binary artifact ..."?
BTW, I noticed that this isn't used for -sources.jar! This is used only for .jar, right?
There was a problem hiding this comment.
We have to ship LICENSE and NOTICE in the jar. That's why these files are in the shaded folder. And LICENSE has to list of dependencies shaded/shipped in the distributed artifact.
52741a9 to
3baabda
Compare
Align versions in
LICENSE/NOTICEin regards of the recent dependency updates.