GH-1125: Read empty ListVector correctly using UnionListReader after IPC deser#1136
Open
bodduv wants to merge 1 commit intoapache:mainfrom
Open
GH-1125: Read empty ListVector correctly using UnionListReader after IPC deser#1136bodduv wants to merge 1 commit intoapache:mainfrom
bodduv wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Contributor
Author
|
I don't think this is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow IPC represents variable-length vectors with an offset buffer containing
valueCount + 1offsets. For an emptyListVector, that still means the serialized and deserialized vector can have a non-empty offset buffer containing the leading zero offset. This is correct according to the Arrow layout, but it exposes a bug atUnionListReader.setPositionand other similar places.UnionListReader.setPosition(0)used offset-buffer capacity as the empty-vector check. That worked only when the offset buffer had zero capacity. After IPC, the empty vector has non-zero offset-buffer capacity, so the reader could throwIndexOutOfBoundsException.UnionLargeListReaderhas the same logical issue and also lacked the empty-buffer guard.What's Changed
Update
UnionListReaderandUnionLargeListReaderto validate reader positioning againstvalueCountinstead of treating offset-buffer capacity as the logical row boundary. All out-of-range positions will throw. For valid non-empty positions, the readers also defensively verify that the offset buffer has enough capacity for bothindexandindex + 1before reading offsets.The shared bounds logic is kept in a package-private
UnionListReaderBoundsCheckerhelper soUnionListReaderandUnionLargeListReaderuse the reuse code.Closes #1125.