fix(c/driver_manager): InternalAdbcUserConfigDir should return parent path#4084
Open
Roshan1299 wants to merge 5 commits intoapache:mainfrom
Open
fix(c/driver_manager): InternalAdbcUserConfigDir should return parent path#4084Roshan1299 wants to merge 5 commits intoapache:mainfrom
Roshan1299 wants to merge 5 commits intoapache:mainfrom
Conversation
…onfigDir Signed-off-by: Roshan1299 <banisettirosh@gmail.com>
…nfigDir call site Signed-off-by: Roshan1299 <banisettirosh@gmail.com>
…ubdirectory Signed-off-by: Roshan1299 <banisettirosh@gmail.com>
zeroshade
reviewed
Mar 12, 2026
| if (levels & ADBC_LOAD_FLAG_SEARCH_USER) { | ||
| // Check the user configuration directory | ||
| std::filesystem::path user_config_dir = InternalAdbcUserConfigDir(); | ||
| std::filesystem::path user_config_dir = InternalAdbcUserConfigDir() / "drivers"; |
Member
There was a problem hiding this comment.
the capitalization has to change based on the system (linux and venvs get "drivers" while Windows and mac get "Drivers")
Author
There was a problem hiding this comment.
Fixed, added a platform-specific kDriversSubdir constant ("Drivers" on Windows/macOS, "drivers" on Linux) and updated the test with the same #ifdef.
| Not(IsOkStatus(&error))); | ||
|
|
||
| auto user_config_dir = InternalAdbcUserConfigDir(); | ||
| auto user_config_dir = InternalAdbcUserConfigDir() / "drivers"; |
Member
There was a problem hiding this comment.
same comment as above, some systems get "Drivers" instead of "drivers"
…rectory Signed-off-by: Roshan1299 <banisettirosh@gmail.com>
Signed-off-by: Roshan1299 <banisettirosh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalAdbcUserConfigDirunnecessarily appended"drivers"to the path even though it is used for both driver manifests and profiles. Each call site now appends the appropriate subdirectory ("drivers"or"profiles") directly.Changes
"drivers"suffix fromInternalAdbcUserConfigDirso it returns the base ADBC config directory on all platforms/ "drivers".parent_path()workaround in profiles, which now appends/ "profiles"directlydriverssubdirectorygo/adbc/drivermgrmirrorFixes #4081