Skip to content

fix(c/driver_manager): test and fix bugs in profiles#4080

Open
lidavidm wants to merge 1 commit intoapache:mainfrom
lidavidm:gh-4024
Open

fix(c/driver_manager): test and fix bugs in profiles#4080
lidavidm wants to merge 1 commit intoapache:mainfrom
lidavidm:gh-4024

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 12, 2026

  • Fix substitution of undefined env var erasing the entire value instead of substituting in a blank string.
  • Improve error messages.
  • Add end-to-end tests with Python.
  • Add end-to-end tests in Conda/virtualenv.
  • Add end-to-end tests with the user path (~/.config, etc.)

This is not complete; see #4082, #4085, #4086, #4087 for things that also need to be fixed, but this establishes a baseline of tests.

Closes #4024.

@lidavidm lidavidm force-pushed the gh-4024 branch 2 times, most recently from 55a69c0 to f3122a4 Compare March 12, 2026 07:27
@lidavidm lidavidm requested a review from amoeba March 12, 2026 07:28
@lidavidm
Copy link
Member Author

@zeroshade @amoeba venvs don't work because we add the additional search path <venv root>/etc/adbc/drivers, and have no way to configure profiles.

Options are:

  • Add the other search path; but then we search both paths for both manifests and profiles, and we risk confusing one for the other.
  • We could additionally require profiles to have a different extension.
  • Instead, we could add a second API function to set another search path. That's starting to get unwieldy.
  • We could ditch the API function, and instead use normal driver options to set additional search paths for drivers/manifests.

@lidavidm lidavidm marked this pull request as ready for review March 13, 2026 04:40
@lidavidm lidavidm requested a review from kou as a code owner March 13, 2026 04:40
@lidavidm
Copy link
Member Author

I need to emphasize that this does not fix everything; see bugs linked above for other things we need to fix still.

@lidavidm lidavidm requested a review from zeroshade March 13, 2026 04:49
@lidavidm
Copy link
Member Author

next PR: #4088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test connection profiles search behaviors before next libraries release

2 participants