Skip to content

feat(format): add table_definition to GetObjects#4050

Open
lidavidm wants to merge 2 commits intoapache:spec-1.2.0from
lidavidm:gh-3984
Open

feat(format): add table_definition to GetObjects#4050
lidavidm wants to merge 2 commits intoapache:spec-1.2.0from
lidavidm:gh-3984

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 5, 2026

Add some more properties to GetObjects. Also, allow drivers to add custom fields for database-specific metadata.

Closes #3984.
Closes #3995.

@lidavidm lidavidm added this to the ADBC API Specification 1.2.0 milestone Mar 11, 2026
@lidavidm lidavidm marked this pull request as ready for review March 11, 2026 06:25
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me!

Comment on lines +2008 to +2010
/// | table_definition | utf8 | (1) |
/// | remarks | utf8 | (2) |
///
Copy link
Member

@paleolimbot paleolimbot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had chatted in the previous issue about adding a serialized Arrow schema here. I don't love the idea of putting Arrow IPC stuffed in a deeply nested Arrow C Array but I'm also in a very small minority of people who is aware of or cares how many lines of code are required to parse it 🙂 . If you'd like to add it it does seem like a good opportunity to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants