feat(csharp): add PII redaction in tracing, by default#4027
Open
birschick-bq wants to merge 8 commits intoapache:mainfrom
Open
feat(csharp): add PII redaction in tracing, by default#4027birschick-bq wants to merge 8 commits intoapache:mainfrom
birschick-bq wants to merge 8 commits intoapache:mainfrom
Conversation
…text for trace activity
Contributor
Author
|
@CurtHagenlocher - let me know if you have some time to review this or if is a low priority for you. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PII redaction in tracing, by default.
The new class
ActivityWithPiiwraps theSystem.Diagnostics.Activityobject and replicates its interface. By default, the methods assume that tag values passed to the methods contain PII, unless explicitly marked otherwise (i.e.,isPii = false).The previous
TraceActivityoverloads and extension method that are useActivityhave been marked asObsolete. They have been replaced with overloads using the newActivityWithPiiclass.As marking the
TraceActivityoverloads and extension methods asObsoletecauses the build to fail, I've update the drivers in two commits. The first commit uses#pragmato ignore the warnings. The second commit, implements the change to use the newActivityWithPiiclass.The
FileExporterandFileListenerhave been updated to reveal the original that have been redacted - with the assumption that writing to the local file system is controlled by an authorized user.