feat(r): support target catalog/schema for ingestion #3852
Conversation
eitsupi
force-pushed
the
r/new-experimental-opts
branch
from
a6c4f5d to
b237e34
Compare
r/adbcdrivermanager/R/helpers.R
Outdated
| #' is not compatible or append otherwise), or `"default"` (use the `adbc.ingest.mode` | ||
| #' argument of [adbc_statement_init()]). The default is `"default"`. | ||
| #' @param catalog_name If not `NULL`, the catalog to create/locate the table in. | ||
| #' **This API is EXPERIMENTAL.** |
There was a problem hiding this comment.
Experimental arguments are often marked using functions in the lifecycle package, but the svg file for the badges will be included in the package.
Is that acceptable?
There was a problem hiding this comment.
I'm not sure I particularly mind the extra .svgs, although I think the all-caps gets the point across just as nicely here.
There was a problem hiding this comment.
After thinking about it, and considering that temporary param, which is equivalently marked as experimental in Python, is not marked as experimental here, I removed the experimental markings as well.
r/adbcdrivermanager/R/helpers.R
Outdated
| #' is not compatible or append otherwise), or `"default"` (use the `adbc.ingest.mode` | ||
| #' argument of [adbc_statement_init()]). The default is `"default"`. | ||
| #' @param catalog_name If not `NULL`, the catalog to create/locate the table in. | ||
| #' **This API is EXPERIMENTAL.** |
There was a problem hiding this comment.
I'm not sure I particularly mind the extra .svgs, although I think the all-caps gets the point across just as nicely here.
2 participants
These experimental options were added to the C and Python bindings in #1056, but were not exposed in the R bindings, so they are added now.