-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: support vertex-ai #12933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: support vertex-ai #12933
Conversation
membphis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor issue
| local function fetch_gcp_access_token(ctx, name, gcp_conf) | ||
| local key = core.lrucache.plugin_ctx_id(ctx, name) | ||
| local access_token = gcp_access_token_cache:get(key) | ||
| if not access_token then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another style:
if access_token then
return access_token
end
-- generate access token
... ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check it when I have time.
Description
Refer to the changes in #12565 to add support for vertex ai.
Already tested in real world:
Which issue(s) this PR fixes:
Fixes #
Checklist