fix(limit-req): ensure safe eviction of keys in redis #12911
Merged
+137
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
shreemaan-abhishek
force-pushed
the
feat/redis-ttl-in-limit-req
branch
from
3fde5b5 to
0aafc22
Compare
nic-6443
previously approved these changes
Jan 16, 2026
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
nic-6443
previously approved these changes
Jan 16, 2026
moonming
previously approved these changes
Jan 16, 2026
shreemaan-abhishek
dismissed stale reviews from moonming and nic-6443
via
292527c
nic-6443
approved these changes
Jan 19, 2026
moonming
approved these changes
Jan 19, 2026
Baoyuantop
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rate limiting keys are created for redis, we need to ensure keys are evicted (removed/expired) safely otherwise stale keys will accumulate over the time, which is not a good practice. Cleanliness is "goodliness".
Checklist