Skip to content

docs: add realm attribute to zh auth plugin docs#12886

Merged
kayx23 merged 7 commits intoapache:masterfrom
Varidhi61:Varidhi61-patch-1
Mar 17, 2026
Merged

docs: add realm attribute to zh auth plugin docs#12886
kayx23 merged 7 commits intoapache:masterfrom
Varidhi61:Varidhi61-patch-1

Conversation

@Varidhi61
Copy link
Copy Markdown
Contributor

@Varidhi61 Varidhi61 commented Jan 9, 2026 •
edited by kayx23
Loading

Add 'realm' parameter to auth plugin documentation.

Description

Which issue(s) this PR fixes:

Fixes #12882

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Varidhi61
docs: add realm description to zh basic-auth route attributes
bf1d6b1 
Add 'realm' parameter to basic-auth plugin documentation.
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. doc Documentation things labels Jan 9, 2026
@kayx23
Copy link
Copy Markdown
Member

kayx23 commented Jan 12, 2026

If you are addressing issue #12882, please update for all these docs:

image

@Varidhi61
Copy link
Copy Markdown
Contributor Author

Varidhi61 commented Jan 12, 2026 via email

@Baoyuantop
Copy link
Copy Markdown
Contributor

Baoyuantop commented Jan 13, 2026

Hi @Varidhi61, changes to these documents can be completed within a single PR. Please refrain from creating duplicate PRs. Continue working on the remaining tasks within this PR, and I will close any other duplicate PRs.

This was referenced Jan 13, 2026
Closed
Closed
Closed
Closed
@Varidhi61
Copy link
Copy Markdown
Contributor Author

Varidhi61 commented Jan 15, 2026

I’ve fixed the Markdown lint issues related to heading spacing.
All requested zh auth plugin updates are now complete.

kayx23
kayx23 reviewed Jan 15, 2026
View reviewed changes
Comment thread docs/zh/latest/plugins/basic-auth.md Outdated
Comment thread docs/zh/latest/plugins/hmac-auth.md Outdated
Comment thread docs/zh/latest/plugins/jwt-auth.md Outdated
Comment thread docs/zh/latest/plugins/key-auth.md Outdated
Comment thread docs/zh/latest/plugins/ldap-auth.md Outdated
kayx23
kayx23 previously approved these changes Jan 15, 2026
View reviewed changes
@kayx23 kayx23 requested a review from Baoyuantop January 15, 2026 08:16
Baoyuantop
Baoyuantop previously approved these changes Jan 20, 2026
View reviewed changes
@Baoyuantop Baoyuantop requested a review from moonming January 20, 2026 02:43
@Varidhi61 Varidhi61 dismissed stale reviews from Baoyuantop and kayx23 via 530be8b January 21, 2026 09:20
@Varidhi61
Copy link
Copy Markdown
Contributor Author

Varidhi61 commented Jan 21, 2026

Hi @kayx23 @Baoyuantop @moonming,
All requested updates have been completed and conflicts resolved.
Please let me know if any further changes are needed.
Thank you for your time and review.

@Baoyuantop
Copy link
Copy Markdown
Contributor

Baoyuantop commented Jan 23, 2026

Hi @Varidhi61, please fix the failed lint CI

@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jan 26, 2026
@Varidhi61
docs: fix markdownlint MD012 in hmac-auth doc
9190bae 
Removed an empty line before the note about schema encryption.
@Varidhi61
Copy link
Copy Markdown
Contributor Author

Varidhi61 commented Jan 26, 2026

The markdown lint issue has been fixed . Thanks!

kayx23
kayx23 previously approved these changes Jan 27, 2026
View reviewed changes
Baoyuantop
Baoyuantop previously approved these changes Jan 28, 2026
View reviewed changes
@Baoyuantop Baoyuantop added awaiting review and removed wait for update wait for the author's response in this issue/PR user responded labels Jan 28, 2026
@Baoyuantop Baoyuantop dismissed stale reviews from kayx23 and themself via fdd299e March 11, 2026 10:12
moonming
moonming reviewed Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@moonming moonming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Varidhi61, thank you for adding the realm description to the Chinese basic-auth documentation!

Keeping Chinese and English documentation in sync is important. I'll verify the translation accuracy shortly.

@Baoyuantop Baoyuantop requested review from kayx23 and moonming March 17, 2026 07:35
@kayx23 kayx23 changed the title docs: add realm description to zh basic-auth route attributes docs: add realm attribute to zh auth plugin docs Mar 17, 2026
@kayx23 kayx23 merged commit 5290139 into apache:master Mar 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moonming moonming moonming approved these changes

@Baoyuantop Baoyuantop Baoyuantop approved these changes

@kayx23 kayx23 kayx23 approved these changes

Assignees

No one assigned

Labels

awaiting review doc Documentation things size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: document realm information in zh docs

4 participants

@Varidhi61 @kayx23 @Baoyuantop @moonming