Skip to content

fix: maintain node_version for independent upstream #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shreemaan-abhishek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: maintain node_version for independent upstream #12856

shreemaan-abhishek wants to merge 3 commits into from
+124 −4

Conversation

@shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Jan 1, 2026 •
edited
Loading

Description

The new decoupled healthcheck_manager logic has missing code to update the version of upstream conf in the case where routes are configured via upstream_id reference.

This version update is necessary for the healtcheck_manager as it relies on that to know that the nodes have changed in order to create correct health checkers for new nodes.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek
fix: maintain node_version for independent upstream (apache#1130)
6f142de 
Signed-off-by: Nic <qianyong@api7.ai>
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
@shreemaan-abhishek shreemaan-abhishek changed the title fix: maintain node_version for independent upstream (#1130) fix: maintain node_version for independent upstream Jan 2, 2026
@shreemaan-abhishek
trailing whitespace
8cffd80 
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review January 2, 2026 04:09
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jan 2, 2026
nic-6443
nic-6443 previously approved these changes Jan 6, 2026
View reviewed changes
@membphis
Copy link
Member

membphis commented Jan 7, 2026

some ci failed, pls fix them first

@shreemaan-abhishek
trailing space
d469ed0 
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nic-6443 nic-6443 nic-6443 left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreemaan-abhishek @membphis @nic-6443