Skip to content

fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response #12853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yuweizzz wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response #12853

yuweizzz wants to merge 5 commits into from

Conversation

@yuweizzz
Copy link
Contributor

@yuweizzz yuweizzz commented Dec 31, 2025

Description

Downgrade etag when in needed.

Which issue(s) this PR fixes:

Fixes #12707

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working plugin labels Dec 31, 2025
Baoyuantop
Baoyuantop reviewed Jan 4, 2026
View reviewed changes
@Baoyuantop Baoyuantop mentioned this pull request Jan 4, 2026
Closed
5 tasks
@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jan 4, 2026
@Baoyuantop Baoyuantop added awaiting review and removed wait for update wait for the author's response in this issue/PR labels Jan 5, 2026
@yuweizzz yuweizzz requested a review from Baoyuantop January 5, 2026 10:24
@Baoyuantop Baoyuantop added wait for update wait for the author's response in this issue/PR and removed awaiting review labels Jan 7, 2026
@yuweizzz
Copy link
Contributor Author

yuweizzz commented Jan 12, 2026

@Baoyuantop

@yuweizzz
Copy link
Contributor Author

yuweizzz commented Jan 20, 2026

any update?

@Baoyuantop Baoyuantop added awaiting review and removed wait for update wait for the author's response in this issue/PR user responded labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Baoyuantop Baoyuantop Baoyuantop approved these changes

@membphis membphis Awaiting requested review from membphis

@nic-6443 nic-6443 Awaiting requested review from nic-6443

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

@AlinsRan AlinsRan Awaiting requested review from AlinsRan

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

awaiting review bug Something isn't working plugin size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ETag and Last-Modified headers are not preserved when response is Brotli-compressed

3 participants

@yuweizzz @Baoyuantop @joshdcu