fix: disallow creating duplicate plugins in global rules #12800
Merged
+418
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
dosubot
bot
added
size:L
nic-6443
reviewed
Dec 9, 2025
nic-6443
reviewed
Dec 9, 2025
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
dosubot
bot
added
size:XL
nic-6443
reviewed
Dec 9, 2025
nic-6443
reviewed
Dec 9, 2025
nic-6443
reviewed
Dec 9, 2025
nic-6443
previously approved these changes
Dec 9, 2025
membphis
previously approved these changes
Dec 12, 2025
bzp2010
reviewed
Dec 14, 2025
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
shreemaan-abhishek
dismissed stale reviews from membphis and nic-6443
via
4df44ed
AlinsRan
reviewed
Dec 17, 2025
apisix/plugin.lua
Outdated
|
|
||
| -- remove duplicate plugins | ||
| for plugin_name, _ in pairs(duplicate_plugins) do | ||
| all_plugins[plugin_name] = nil |
Contributor
There was a problem hiding this comment.
We should warn which plugins are not working.
Contributor
Author
There was a problem hiding this comment.
you are right, thanks. I pushed a new commit that contains:
core.log.warn("found ", plugin_name, " configured across different global rules ",
" it won't get executed")
Contributor
There was a problem hiding this comment.
I think duplicate_plugins are redundant.
Can we merge three loops into one?
bzp2010
previously approved these changes
Dec 19, 2025
AlinsRan
previously approved these changes
Dec 19, 2025
nic-6443
previously approved these changes
Dec 19, 2025
shreemaan-abhishek
dismissed stale reviews from nic-6443, AlinsRan, and bzp2010
via
0e6c6ce
Member
|
lots of CI failed |
nic-6443
changed the title
nic-6443
previously approved these changes
Jan 7, 2026
membphis
reviewed
Jan 7, 2026
apisix/plugin.lua
Outdated
| if global_rule.value and global_rule.value.plugins then | ||
| for plugin_name, plugin_conf in pairs(global_rule.value.plugins) do | ||
| if seen_plugin[plugin_name] then | ||
| core.log.warn("Found ", plugin_name, |
Member
There was a problem hiding this comment.
it is an important error message
Member
There was a problem hiding this comment.
if we used one plugin about 3 or 5 times
we should throw an error in this case
current way seems wrong
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
nic-6443
approved these changes
Jan 8, 2026
membphis
approved these changes
Jan 8, 2026
Baoyuantop
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the same plugin is configured across different global rules, there will be no guarantee on which plugin config will be executed first. Additionally, the current architecture does not guarantee plugin execution order according to the priority.
We address this problem by disallowing configuring same plugin across multiple global_rules and sorting the plugins to their priority and executing in order.
Fixes: #12704
Checklist