UI: Add option to clear/mark all mapped task instances #63857
Closed
haseebmalik18 wants to merge 9 commits intoapache:mainfrom
Closed
UI: Add option to clear/mark all mapped task instances #63857haseebmalik18 wants to merge 9 commits intoapache:mainfrom
haseebmalik18 wants to merge 9 commits intoapache:mainfrom
Conversation
haseebmalik18
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:translations
area:UI
Member
|
another flaky parts🥲 |
haseebmalik18
changed the title
Contributor
|
I actually was looking for the buttons - UI changes are always cool if they have a screenshot, perfect if "before" + "after". But an after at least would be cool to see "where" on the UI the change is. |
haseebmalik18
force-pushed
the
ui-clear-all-mapped-ti
branch
from
8d0887e to
028b6a2
Compare
Contributor
Author
|
Before changes: 
After changes: 
|
Contributor
Okay, now I see where it goes. I think actually the case is often also that a selective set, e.g. all failed tasks of a mapped task must be restarted. So I think the proposal by @shubhamraj-git is a bit more fitting to purpose, see #64141 - WDYT? |
Contributor
Author
|
Ah, I misunderstood. Yes, I agree #64141 is more fitting for this. I can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing a mapped task instance, the clear and mark as dialogs now show checkboxes to apply the action to all mapped task instances. When checked, the requests send just the task_id without map_index, which the backend already supports to target all map indices of a mapped task.
closes: #60460