Introduce parent task spans and nest worker and trigger spans under them#63839
Merged
dstandish merged 38 commits intoapache:mainfrom Mar 24, 2026
Merged
Introduce parent task spans and nest worker and trigger spans under them#63839dstandish merged 38 commits intoapache:mainfrom
dstandish merged 38 commits intoapache:mainfrom
Conversation
dstandish
requested review from
XD-DENG,
amoghrajesh,
ashb,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
hussein-awala,
jason810496,
kaxil,
o-nikolas,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
dstandish
force-pushed
the
parent-task-span
branch
from
1e8cecf to
89ef70a
Compare
Contributor
Author
dstandish
force-pushed
the
parent-task-span
branch
from
89ef70a to
ffde871
Compare
Contributor
|
I changed the -@task
-def task1():
- logger.info("starting task1")
+class Task1(BaseOperator):
+ def execute(self, context):
+ self.defer(
+ trigger=TimeDeltaTrigger(timedelta(minutes=1)),
+ method_name="execute_complete",
+ )
+
+ def execute_complete(self, context, event=None):
+ logger.info("starting task1")
- with tracer.start_as_current_span("sub_span1") as s1:
- s1.set_attribute("attr1", "val1")
-
- logger.info("task1 finished.")
+ with tracer.start_as_current_span("sub_span1") as s1:
+ s1.set_attribute("attr1", "val1")
+ logger.info("task1 finished.")
with DAG(
"otel_test_dag",
default_args=args,
schedule=None,
catchup=False,
) as dag:
- task1()
+ Task1(task_id="task1")This is the result 
The span for the task1 doesn't appear as a child of the dag_run span. It looks like that's the case in your screenshot as well. |
Contributor
Author
oh interesting you are right thanks for pointing that out this stuff is so tricky |
xBis7
reviewed
Mar 18, 2026
Contributor
xBis7
left a comment
xBis7
left a comment
There was a problem hiding this comment.
@dstandish Thanks for the PR! I posted a few questions.
Contributor
Author
ok @xBis7 i think i fixed it! i updated the screen shot in the description. confirm when you have a chance! |
Contributor
@dstandish I tested it locally and now it looks good! |
This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
xBis7
approved these changes
Mar 19, 2026
Contributor
xBis7
left a comment
xBis7
left a comment
There was a problem hiding this comment.
Thanks for addressing all my comments! You've mentioned that you tested it with mapped tasks and fixed an issue. Pending a green CI.
LGTM!
This was referenced Mar 21, 2026
Move all local opentelemetry and observability imports to the top of each test file, fix TestMakeTaskCarrier fixture to also patch the shared lib tracer so new_task_run_carrier(None) works correctly, and fix assertion indentation in test_emit_dagrun_span_with_none_or_empty_carrier.
jedcunningham
approved these changes
Mar 23, 2026
test_insert_mapping_includes_context_carrier and test_clear_task_instances_resets_context_carrier only patched airflow.models.taskinstance.tracer, but new_task_run_carrier uses the tracer from airflow._shared.observability.traces. Without patching that, older OTel versions (LowestDeps CI) produce an invalid span and an empty carrier. Apply the same fix already used in TestMakeTaskCarrier.
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 25, 2026
…hem (#63839) This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Mar 30, 2026
…hem (apache#63839) This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…hem (apache#63839) This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…hem (apache#63839) This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
xBis7
added a commit
to xBis7/airflow
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us tie together the worker and trigger phases of task execution. Also lets us see the delta between task queued time and task start time.
example output