Fix RenderedJsonField collapse behavior#63831
Merged
pierrejeambrun merged 3 commits intoapache:mainfrom Mar 18, 2026
Merged
Conversation
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:translations
area:UI
pierrejeambrun
force-pushed
the
fix-renderedjsonfield-collapse
branch
from
e187217 to
c691464
Compare
amoghrajesh
approved these changes
Mar 18, 2026
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Not an expert but the screenshots look good. Could use another approval from UI folks.
amoghrajesh
changed the title
vatsrahul1001
approved these changes
Mar 18, 2026
pierrejeambrun
added
the
full tests needed
pierrejeambrun
removed
the
full tests needed
Member
Author
|
Need to adjust, this is causing other problems. Basically we need to keep the monaco editor everywhere instead of replacing with 'code'. (loosing the ability to single expand, etc...) edit: Adjusted |
pierrejeambrun
force-pushed
the
fix-renderedjsonfield-collapse
branch
from
a54b61b to
b94b5f8
Compare
2 tasks
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Mar 18, 2026
* Fix RenderedJsonField collapse behavior * Fix renderedjson field collapase * Keep monaco editor always
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Mar 18, 2026
* Fix RenderedJsonField collapse behavior * Fix renderedjson field collapase * Keep monaco editor always
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
* Fix RenderedJsonField collapse behavior * Fix renderedjson field collapase * Keep monaco editor always
techcodie
pushed a commit
to techcodie/airflow
that referenced
this pull request
Mar 23, 2026
* Fix RenderedJsonField collapse behavior * Fix renderedjson field collapase * Keep monaco editor always
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
* Fix RenderedJsonField collapse behavior * Fix renderedjson field collapase * Keep monaco editor always
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the height of the editor not collapsing when the json was collapsed. (it would keep occupying the same vertical space)
Before
After
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.