Skip to content

Unify usage of AIRFLOW_REPO_ROOT in PMC testing docs#61238

Merged
amoghrajesh merged 2 commits intomainfrom
amoghrajesh-patch-1
Jan 30, 2026
Merged

Unify usage of AIRFLOW_REPO_ROOT in PMC testing docs#61238
amoghrajesh merged 2 commits intomainfrom
amoghrajesh-patch-1

Conversation

@amoghrajesh
Copy link
Copy Markdown
Contributor


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is needed, else shellcheck will complaint.

Why do you think the quotes should be removed?

@amoghrajesh
Copy link
Copy Markdown
Contributor Author

Guess it depends on the shell. I am doing this with reference to line 722 above: https://github.com/apache/airflow/pull/61238/changes#diff-1ef4f02ce0e55bffd7245e78c55bd83bfab647c6d4e6c8dc7925405398871371L722 to unify it

@jscheffl
Copy link
Copy Markdown
Contributor

Guess it depends on the shell. I am doing this with reference to line 722 above: https://github.com/apache/airflow/pull/61238/changes#diff-1ef4f02ce0e55bffd7245e78c55bd83bfab647c6d4e6c8dc7925405398871371L722 to unify it

Okay, then according to shellcheck it should have quotes consistently. Else is whitespace in path (unlikely but possible) arguments are split.

@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented Jan 30, 2026

I think that we could settle on:

cd "$AIRFLOW_REPO_ROOT"

With quotes, without curly braces.

🙂

@amoghrajesh
Copy link
Copy Markdown
Contributor Author

Yea seems like a good idea

Copy link
Copy Markdown
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM but please do not forget to update the title ;)

@amoghrajesh amoghrajesh changed the title Removing extra quotes in PMC testing doc for providers Unify usage of AIRFLOW_REPO_ROOT in PMC testing docs Jan 30, 2026
@amoghrajesh
Copy link
Copy Markdown
Contributor Author

Yep, done!

@amoghrajesh amoghrajesh merged commit 88d10b9 into main Jan 30, 2026
71 checks passed
@amoghrajesh amoghrajesh deleted the amoghrajesh-patch-1 branch January 30, 2026 17:30
morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants