Unify usage of AIRFLOW_REPO_ROOT in PMC testing docs#61238
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
For me this is needed, else shellcheck will complaint.
Why do you think the quotes should be removed?
|
Guess it depends on the shell. I am doing this with reference to line 722 above: https://github.com/apache/airflow/pull/61238/changes#diff-1ef4f02ce0e55bffd7245e78c55bd83bfab647c6d4e6c8dc7925405398871371L722 to unify it |
Okay, then according to shellcheck it should have quotes consistently. Else is whitespace in path (unlikely but possible) arguments are split. |
|
I think that we could settle on: With quotes, without curly braces. 🙂 |
|
Yea seems like a good idea |
vincbeck
left a comment
There was a problem hiding this comment.
LGM but please do not forget to update the title ;)
AIRFLOW_REPO_ROOT in PMC testing docs
|
Yep, done! |
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.