Add additional user variables during node and edge transform#2199
Closed
jrgemignani wants to merge 1 commit intoapache:masterfrom
Closed
Add additional user variables during node and edge transform#2199jrgemignani wants to merge 1 commit intoapache:masterfrom
jrgemignani wants to merge 1 commit intoapache:masterfrom
Conversation
This PR adds additional variables to a node and edge during the
transform node/edge phase, provided that a variable was specified
for the node or edge.
These additional variables are added to allow direct access to the
columns of the specific node or edge. These variables can be used
to improve the performance of some queries.
Variables added have the following suffixes to the node or edge
variable name -
_idc ID Column
_propertiesc PROPERTIES Column
_start_idc EDGE START_ID Column
_end_idc EDGE END_ID Column
For example -
MATCH (u) RETURN u, u_idc, u_propertiesc
Regression tests added.
modified: regress/expected/cypher_match.out
modified: regress/sql/cypher_match.sql
modified: src/backend/parser/cypher_clause.c
modified: src/backend/parser/cypher_item.c
modified: src/backend/utils/adt/agtype.c
modified: src/include/parser/cypher_parse_node.h
Contributor
Author
|
@MuhammadTahaNaveed Please test and suggest additional regression tests, if you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional variables to a node and edge during the transform node/edge phase, provided that a variable was specified for the node or edge.
These additional variables are added to allow direct access to the columns of the specific node or edge. These variables can be used to improve the performance of some queries.
Variables added have the following suffixes to the node or edge variable name -
For example -
Regression tests added.