WIP: [AMQ-9798] Refactored Web Console and removed dependency on Spring-MVC.#1523
WIP: [AMQ-9798] Refactored Web Console and removed dependency on Spring-MVC.#1523sergio-d-lemos wants to merge 3 commits intoapache:mainfrom
Conversation
|
Can we also write some tests for the change? Great initiative! |
Yes, if we don't need any major change to the PR I will include some unit tests. At least for the classes I've added |
|
That's a nice PR, thanks ! At first glance, it looks good to me. I don't think we would need additional tests compared to what we have today. However, I think the Karaf features have to be updated to cleanup the dependency there as well. I can help on this front. Let me do a complete review. |
Thanks JB, I'm not very familiar with Karaf, appreciate any help on this front, I can also take a look. |
This PR removes the dependency on Spring MVC and does some clean ups in the Web Console. Apologize for the long PR.
I tested each page using Chrome and did some sanity tests using Firefox. I was unable to test running the console on an OSGI container, but I can test if we think is necessary.