fix(security-guidance): output structured JSON so model receives security warnings#29097
Open
4RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
Open
fix(security-guidance): output structured JSON so model receives security warnings#290974RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
4RH1T3CT0R7 wants to merge 1 commit intoanthropics:mainfrom
Conversation
…ings The hook wrote plain text to stderr with exit code 2, but the model never received the security warning in its context. The hookify plugin demonstrates the correct pattern: output JSON to stdout with hookSpecificOutput.permissionDecision and systemMessage fields. Switch to stdout JSON with permissionDecision:"deny" and exit 0, matching the established hook protocol. This ensures Claude sees security warnings and can act on them. Fixes anthropics#18509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exit(2)hookSpecificOutput.permissionDecisionandsystemMessagefieldsChanges
plugins/security-guidance/hooks/security_reminder_hook.pylines 271-273: replacedprint(reminder, file=sys.stderr)+sys.exit(2)with structured JSON output to stdout +sys.exit(0)rule_engine.pylines 72-79)Before
After
Test plan
.github/workflows/*.ymlfile — Claude should see the security warning in its context and deny the operationeval(— same behaviorFixes #18509