fix: prevent SIGINT/SIGTERM propagation to Claude subprocess#617
Open
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: prevent SIGINT/SIGTERM propagation to Claude subprocess#617Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Conversation
Add start_new_session=True to the open_process call so the Claude CLI subprocess runs in its own process group. This prevents signals like SIGINT and SIGTERM from propagating from the parent process to the subprocess, allowing graceful shutdown patterns where the parent stops accepting new work while the current agent task completes. The SDK already terminates the subprocess explicitly in its close() method, so this change does not affect normal cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the parent process receives SIGINT or SIGTERM, the signal propagates to the Claude CLI subprocess, causing it to exit immediately (exit code -2). This breaks graceful shutdown patterns where the parent stops accepting new work while allowing in-flight agent tasks to complete.
Fixes #610
Changes
Add
start_new_session=Trueto theanyio.open_process()call inSubprocessCLITransport._start_process(). This puts the Claude CLI subprocess in its own process group so it does not receive signals sent to the parent's process group.The SDK already terminates the subprocess explicitly via
Process.terminate()in theclose()method, so normal cleanup is unaffected.Testing
ruff checkpasses with no issues