fix: skip user parameter in open_process on Windows#616
Open
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: skip user parameter in open_process on Windows#616Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Conversation
The `user` parameter for running subprocesses as a different user is not supported on Windows and causes `NotImplementedError` in asyncio's subprocess transport. Conditionally include the `user` parameter only on non-Windows platforms so the SDK works on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, passing the
userparameter toanyio.open_process()raisesNotImplementedErrorbecause asyncio's subprocess transport does not support running processes as a different user on Windows.Fixes #546
Changes
userparameter only on non-Windows platforms inSubprocessCLITransport._start_process()useris not passed toopen_processwhen platform is WindowsTesting
ruff checkpasses with no issues