fix: use errors='replace' in TextReceiveStream to handle malformed UTF-8#615
Open
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: use errors='replace' in TextReceiveStream to handle malformed UTF-8#615Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Br1an67 wants to merge 1 commit intoanthropics:mainfrom
Conversation
When MCP servers or other child processes write non-UTF-8 bytes or concurrent writes cause byte stream reordering, TextReceiveStream raises UnicodeDecodeError with the default strict error handler. Pass errors='replace' so that malformed byte sequences are replaced with the Unicode replacement character instead of crashing the SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When MCP servers or other child processes write non-UTF-8 bytes, or when concurrent writes cause byte stream reordering,
TextReceiveStreamraisesUnicodeDecodeErrorwith the defaultstricterror handler, crashing the SDK.Fixes #549
Changes
Pass
errors='replace'toTextReceiveStreamfor both stdout and stderr streams inSubprocessCLITransport._start_process(). This replaces malformed byte sequences with the Unicode replacement character (U+FFFD) instead of raising an exception.Testing
ruff checkpasses with no issues