Skip to content

Listing 9.2 - Deprecations #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ITHelpDec wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Listing 9.2 - Deprecations #46

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5378c6c
opt for `std::make_unique<>` over `operator new`
ITHelpDec Jul 8, 2023
a12f8ac
`std::result_of` -> `std::invoke_result_t`
ITHelpDec Jul 8, 2023
797213f
use of `noexcept` with move(-assignment) operations
ITHelpDec Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions listings/listing_9.2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ class function_wrapper
};
public:
template<typename F>
function_wrapper(F&& f):
impl(new impl_type<F>(std::move(f)))
function_wrapper(F&& f) noexcept:
impl(std::make_unique<impl_type<F>>(std::move(f)))
{}

void call() { impl->call(); }

function_wrapper(function_wrapper&& other):
function_wrapper(function_wrapper&& other) noexcept:
impl(std::move(other.impl))
{}

function_wrapper& operator=(function_wrapper&& other)
function_wrapper& operator=(function_wrapper&& other) noexcept
{
impl=std::move(other.impl);
return *this;
Expand All @@ -48,10 +48,10 @@ class thread_pool
std::deque<function_wrapper> work_queue;

template<typename FunctionType>
std::future<typename std::result_of<FunctionType()>::type>
std::future<std::invoke_result_t<FunctionType&&>>
submit(FunctionType f)
{
typedef typename std::result_of<FunctionType()>::type result_type;
typedef std::invoke_result_t<FunctionType&&> result_type;

std::packaged_task<result_type()> task(std::move(f));
std::future<result_type> res(task.get_future());
Expand Down