fix(opencode): reorder write tool schema to declare filePath before c…#29943
Open
RheagalFire wants to merge 1 commit into
Open
fix(opencode): reorder write tool schema to declare filePath before c…#29943RheagalFire wants to merge 1 commit into
RheagalFire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29940
Type of change
What does this PR do?
Reorders the write tool schema to declare
filePathbeforecontent. Local models generate fields in declaration order, so when writing large files they can exhaust their tokenbudget on
contentand never producefilePath, causing a schema error.Suggested by @strasharo in #26419.
Related: #18108
How did you verify your code works?
Verified the schema change compiles and the field order is correct. The fix is a single line swap with no behavioral change for models that generate all fields.
Screenshots / recordings
N/A
Checklist