fix(desktop): collapse full-context git diffs#29928
Open
dayhaysoos wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #29768 #21068
Type of change
What does this PR do?
Desktop Git Changes receives generated patches with full-file context, so the diff view was rendering entire files instead of only changed regions.
This detects full-context generated patches, reconstructs the before/after file contents from the patch, and passes those contents through the existing diff renderer. That lets unchanged regions collapse again. Partial patches still use the existing patch parsing path so normal hunk boundaries are preserved.
Partial patches still use the existing patch parsing path.
How did you verify your code works?
bun --cwd packages/ui test src/components/session-diff.test.tsbun --cwd packages/ui typecheckbun typecheckgit diff --checkScreenshots / recordings
Recording:
open-code-pr-1.mp4
Checklist